Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pinned notes using bbolt #9

Merged
merged 9 commits into from
Dec 13, 2024
Merged

feat: add pinned notes using bbolt #9

merged 9 commits into from
Dec 13, 2024

Conversation

JackWilli
Copy link
Contributor

No description provided.

@JackWilli JackWilli requested a review from ptdewey December 8, 2024 18:37
should create the dir if it doesn't exist
main.go Outdated Show resolved Hide resolved
internal/db/db.go Outdated Show resolved Hide resolved
@JackWilli JackWilli requested a review from ptdewey December 11, 2024 23:08
Moved db close defer to avoid potential race condition
internal/config/config.go Outdated Show resolved Hide resolved
@ptdewey
Copy link
Member

ptdewey commented Dec 11, 2024

Also make sure to update the example config and readme with the new option(s) you add

Copy link
Member

@ptdewey ptdewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need the new config options documented before merging

@JackWilli JackWilli requested a review from ptdewey December 13, 2024 17:37
Copy link
Member

@ptdewey ptdewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JackWilli JackWilli merged commit 21229f5 into main Dec 13, 2024
1 check passed
@JackWilli JackWilli deleted the pinning branch December 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants